Cleanup global event listeners #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-124/ |
snatvb
reviewed
Sep 14, 2025
snatvb
reviewed
Sep 14, 2025
snatvb
reviewed
Sep 14, 2025
snatvb
approved these changes
Sep 17, 2025
| } | ||
|
|
||
| /// Run some cleanup code when the component is unmounted if the effect was run. | ||
| fn use_effect_with_cleanup<F: FnMut() -> C + 'static, C: FnOnce() + 'static>(mut effect: F) { |
There was a problem hiding this comment.
Could you please add this to the framework or a utils crate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any global event listeners components use when the component is removed
Depends on DioxusLabs/dioxus#4655
Fixes #123